Skip to content

Conversation

@sbernauer
Copy link
Member

@sbernauer sbernauer commented Oct 29, 2025

Description

Part of stackabletech/issues#770
Pulls in stackabletech/operator-rs#1107

IONOS loadbalances don't support the Local traffic policy. so demos and tests didn't work put of the box on IONOS.
This PR changes to safer default (null), see the release notes below.

Release notes

  • Breaking: Default ListenerClass .spec.externalTrafficPolicy to null to improve LoadBalancer support across various Kubernetes environments.
    Previously, ListenerClasses used Local by default, which can be more performant, but needs to be supported by the LoadBalancer.
    Setting this field no null forwards the defaulting to the Kubernetes API server, which internally defaults to Cluster.
    This change can result in degraded performance when the field was previously unconfigured, therefore it is marked as a breaking change.
    The field can explicitly be set to Local to restore the old behavior.
    See https://github.com/stackabletech/listener-operator/pull/347[listener-operator#347].

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@sbernauer sbernauer added release-note Denotes a PR that will be considered when it comes time to generate release notes. release-note/action-required Denotes a PR that introduces potentially breaking changes that require user action. scheduled-for/25.11.0 labels Oct 29, 2025
@sbernauer sbernauer self-assigned this Oct 29, 2025
@sbernauer sbernauer moved this to Development: Waiting for Review in Stackable Engineering Oct 29, 2025
@NickLarsenNZ NickLarsenNZ self-requested a review October 31, 2025 06:53
@NickLarsenNZ NickLarsenNZ moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Oct 31, 2025
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sbernauer sbernauer added this pull request to the merge queue Oct 31, 2025
@sbernauer sbernauer moved this from Development: In Review to Development: Done in Stackable Engineering Oct 31, 2025
Merged via the queue into main with commit c8bccc1 Oct 31, 2025
17 checks passed
@sbernauer sbernauer deleted the fix/default-traffic-policy-to-null branch October 31, 2025 07:40
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Nov 11, 2025
@lfrancke lfrancke moved this from Done to Acceptance: In Progress in Stackable Engineering Nov 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release/25.11.0 release-note/action-required Denotes a PR that introduces potentially breaking changes that require user action. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

Status: Acceptance: In Progress

Development

Successfully merging this pull request may close these issues.

3 participants